feat(core): add cloud_auth config + credential persistence - #1054
Merged
KrumTy merged 1 commit intoJul 27, 2026
Merged
Conversation
KrumTy
marked this pull request as ready for review
July 24, 2026 12:02
KrumTy
force-pushed
the
feat/RED-210012/1/cloud-auth-core
branch
from
July 24, 2026 12:57
000dda9 to
ae45692
Compare
KrumTy
force-pushed
the
feat/RED-210013/2/cloud-auth-config
branch
from
July 24, 2026 12:59
3e9810a to
e3f5363
Compare
valkirilov
approved these changes
Jul 27, 2026
KrumTy
force-pushed
the
feat/RED-210013/2/cloud-auth-config
branch
from
July 27, 2026 11:56
e3f5363 to
74a76de
Compare
Base automatically changed from
feat/RED-210012/1/cloud-auth-core
to
feat/RED-209367/agent-cloud-provisioning
July 27, 2026 12:05
Adds the config surface that turns a minted API key into a usable profile: - `[cloud_auth.<profile>]` section (`CloudAuthConfig`: okta_issuer, client id, sm_api_url, capi_url) with built-in production defaults and an `is_complete()` check; kept separate from stored credentials since it describes *how to log in*, not the resulting keys. - `Config::resolve_cloud_auth` (profile entry, else prod defaults) and `Config::apply_cloud_login`, which writes an `auth::MintedCredentials` into a normal cloud profile (keyring by default via `CredentialStore`, plaintext fallback) and records the login endpoints for re-login. - `CredentialStore::plaintext()` for the `--allow-plaintext` path. Additive; no existing config behaviour changes. Integration-tested (round-trip, prod-default fallback, profile persistence). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
KrumTy
force-pushed
the
feat/RED-210013/2/cloud-auth-config
branch
from
July 27, 2026 12:10
74a76de to
bbab913
Compare
KrumTy
merged commit Jul 27, 2026
28c1aa4
into
feat/RED-209367/agent-cloud-provisioning
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the configuration surface that turns an OIDC-minted Redis Cloud API key into a usable
cloud profile. It defines where a profile's login endpoints live and how the resulting key is
persisted.
[cloud_auth.<profile>]config section (CloudAuthConfig: Okta issuer, client id, SM APIbase, CAPI base) with built-in production defaults. Kept separate from stored credentials
because it describes how to log in, not the resulting keys.
Config::resolve_cloud_auth— a profile's endpoints, or the production defaults when unset.Config::apply_cloud_login— writes a minted credential into a normal cloud profile (OSkeyring by default via
CredentialStore, plaintext fallback) and records the login endpointsso re-login works after the key is cleared.
CredentialStore::plaintext()for the explicit no-keyring path.Fully additive: no existing config behaviour changes.
Scope
crates/redisctl-core/src/config/*,src/lib.rs(re-exports).CloudAuthConfig; newConfig::resolve_cloud_authandConfig::apply_cloud_login;CredentialStore::plaintext(). No existing APIs changed.Testing
cargo test -p redisctl-core # lib tests + cloud_auth_config integration testscargo clippy --workspace --all-targets --all-features -- -D warningsChecklist